Fix Add method when table name is null. #410 #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igitur
requested changes
Jul 18, 2017
| @@ -278,13 +278,16 @@ | |||
| <EmbeddedResource Include="Resource\Examples\Ranges\AddingRowToTables.xlsx" /> | |||
| <EmbeddedResource Include="Resource\Examples\Misc\RightToLeft.xlsx" /> | |||
| <EmbeddedResource Include="Resource\Examples\PivotTables\PivotTables.xlsx" /> | |||
| <None Include="packages.config" /> | |||
| <None Include="packages.config"> | |||
| @@ -24,7 +24,7 @@ IEnumerator IEnumerable.GetEnumerator() | |||
|
|
|||
| public void Add(IXLTable table) | |||
| { | |||
| _tables.Add(table.Name, table); | |||
| _tables.Add(table.Name ?? String.Empty, table); | |||
There was a problem hiding this comment.
This will lead to duplicate keys if the file contains multiple nameless tables.
|
Fixed in #412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Fixes issue #410
Where should the reviewer start?
From the new unit test.
How should this be manually tested?
By trying to edit the file using ClosedXML.
Any background context you want to provide?
The file was initially created with ClosedXML and edited using Google Spreadsheet.
Screenshots (if appropriate)
Questions:
Is there a blog post? No
Does the knowledge base need an update? No
Does this add new (C#) dependencies? No
C# Code Review: @csreviewer
Test Automation Review: @csreviewer