Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ridiculous, but valid formulas, e.g. =+++++++MID(A3,3,5) #440

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Allow ridiculous, but valid formulas, e.g. =+++++++MID(A3,3,5) #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions ClosedXML/Excel/CalcEngine/CalcEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,11 @@ public Expression Parse(string expression)

// skip leading equals sign
if (_len > 0 && _expr[0] == '=')
{
_ptr++;
}

// skip leading +'s
while (_len > _ptr && _expr[_ptr] == '+')
_ptr++;

// parse the expression
var expr = ParseExpression();
Expand Down
17 changes: 17 additions & 0 deletions ClosedXML_Tests/Excel/Misc/FormulaTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,5 +156,22 @@ public void FormulaThatReferencesEntireColumn()
Assert.AreEqual(6, actual);
}
}

[Test]
public void FormulaThatStartsWithEqualsAndPlus()
{
object actual;
actual = XLWorkbook.EvaluateExpr("=MID(\"This is a test\", 6, 2)");
Assert.AreEqual("is", actual);

actual = XLWorkbook.EvaluateExpr("=+MID(\"This is a test\", 6, 2)");
Assert.AreEqual("is", actual);

actual = XLWorkbook.EvaluateExpr("=+++++MID(\"This is a test\", 6, 2)");
Assert.AreEqual("is", actual);

actual = XLWorkbook.EvaluateExpr("+MID(\"This is a test\", 6, 2)");
Assert.AreEqual("is", actual);
}
}
}