Parse and convert to string using invariant culture #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igitur
changed the title
igitur
force-pushed
the
numberstyle-and-parse-culture-fixes
branch
from
f515d46
to
e5c8131
Compare
|
it seems to be passing now, are you good with a merge ? |
|
Yup, you can merge. |
AmirBosch
approved these changes
Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running en-ZA culture on my Linux box at home and currently this causes parsing problems with numbers. Numbers have to be stored and parsed according to the invariant culture.
Don't merge this PR yet. I just want to see whether it passes the tests on AppVeyor (which is a Windows machine).