Disallow table with null .DataRange when saving #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igitur
force-pushed
the
dont-allow-table-with-empty-datarange
branch
from
306558e
to
f90e52e
Compare
igitur
changed the title
Pankraty
reviewed
Jun 27, 2018
|
|
||
| namespace ClosedXML.Excel.Exceptions | ||
| { | ||
| public class EmptyTableException : Exception |
There was a problem hiding this comment.
What do you think about inheriting all ClosedXML exceptions from a single one (e.g. abstract ClosedXmlException)? This would make them easier to catch.
igitur
force-pushed
the
dont-allow-table-with-empty-datarange
branch
2 times, most recently
from
ab5f76f
to
be7317a
Compare
Pankraty
requested changes
Jul 2, 2018
| public abstract class ClosedXMLException : Exception | ||
| { | ||
| protected ClosedXMLException() | ||
| : base() |
ClosedXML/Excel/Tables/XLTable.cs
Outdated
|
|
||
| public IXLRange AppendData(IEnumerable data, bool transpose) | ||
| { | ||
| if (data == null || data is String) |
There was a problem hiding this comment.
There should also be a check for the empty collection, I suppose.
There was a problem hiding this comment.
Thanks, will address in #908
ClosedXML/Excel/Tables/XLTable.cs
Outdated
|
|
||
| public IXLRange ReplaceData(IEnumerable data, bool transpose) | ||
| { | ||
| if (data == null || data is String) |
There was a problem hiding this comment.
Same here - check if the collection is empty and add a test for it.
igitur
force-pushed
the
dont-allow-table-with-empty-datarange
branch
from
be7317a
to
d2b72b6
Compare
|
Yes, will rebase this. Whenever I say "depends on", that is my intention. |
igitur
force-pushed
the
dont-allow-table-with-empty-datarange
branch
from
d2b72b6
to
550b6af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
#908Throws exception when trying to save a file with a table with no datarange.