Improve message in preconditions

ClotildeToullec · Feb 22, 2021 · 0c4bf7d · 0c4bf7d
1 parent 690d71d
commit 0c4bf7d
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/Refactoring-Core/RBTemporaryToInstanceVariableRefactoring.class.st b/src/Refactoring-Core/RBTemporaryToInstanceVariableRefactoring.class.st
@@ -67,6 +67,12 @@ RBTemporaryToInstanceVariableRefactoring >> class: aClass selector: aSelector va
 RBTemporaryToInstanceVariableRefactoring >> preconditions [
 	^(RBCondition definesSelector: selector in: class)
 		& (RBCondition definesInstanceVariable: temporaryVariableName asString in: class) not
+		& (RBCondition withBlock: [ 
+			(class allSubclasses anySatisfy: 
+				[ :cls | cls definesInstanceVariable: temporaryVariableName asString ])
+			ifTrue: [ self refactoringWarning: 
+				('One or more subclasses of <1p> already defines an<n>instance variable with the same name. Proceed anyway?' expandMacrosWith: class name) ].
+			true ])
 			& (RBCondition withBlock: 
 						[self checkForValidTemporaryVariable.
 						true])