Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC diagrams based on diagrams.net #158

Merged
merged 5 commits into from
Nov 10, 2020
Merged

VPC diagrams based on diagrams.net #158

merged 5 commits into from
Nov 10, 2020

Conversation

meshuga
Copy link
Member

@meshuga meshuga commented Nov 8, 2020

image

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #158 (7d7ecd3) into develop (bc8c4f4) will increase coverage by 3.93%.
The diff coverage is 79.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #158      +/-   ##
===========================================
+ Coverage    19.30%   23.24%   +3.93%     
===========================================
  Files           45       46       +1     
  Lines         2989     3184     +195     
===========================================
+ Hits           577      740     +163     
- Misses        2412     2444      +32     
Impacted Files Coverage Δ
cloudiscovery/provider/vpc/resource/network.py 0.00% <0.00%> (ø)
cloudiscovery/shared/common_aws.py 24.02% <0.00%> (ø)
setup.py 0.00% <ø> (ø)
cloudiscovery/shared/common.py 71.95% <50.00%> (-0.28%) ⬇️
cloudiscovery/shared/diagram.py 51.85% <63.52%> (+12.89%) ⬆️
cloudiscovery/provider/vpc/diagram.py 97.27% <100.00%> (ø)
cloudiscovery/shared/diagramsnet.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8c4f4...7d7ecd3. Read the comment docs.

@leandrodamascena leandrodamascena marked this pull request as ready for review November 10, 2020 10:41
Copy link
Member

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Approved :D

@meshuga meshuga merged commit ff3605f into develop Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants