Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to change the status of a submission by challenge host #2210

Closed
RishabhJain2018 opened this issue Mar 19, 2019 · 7 comments
Closed

Comments

@RishabhJain2018
Copy link
Member

Current Scenario

If a challenge host wants to cancel the submission status of submission, then they can't do it. They have to approach EvalAI admin in order to do it.

Expected Scenario

The challenge host should be able to change the submission status using UI.

@mahim23
Copy link

mahim23 commented Mar 19, 2019

@RishabhJain2018 can I work on this?

@RishabhJain2018
Copy link
Member Author

Sure, I was about to mention you :)

@mahim23
Copy link

mahim23 commented Mar 20, 2019

Hey @RishabhJain2018 , I was going through the repo trying to figure out how it works and the changes I need to make. So as I've understood, I need to

  • give a provision for the "host" of the challenge in the UI to change the status of any submission (to any of the possible STATUS_OPTIONS?).
  • provide an API endpoint in django to change the status and save it.

Did I miss anything? I've started working on the backend and will send a WIP PR soon.

@RishabhJain2018
Copy link
Member Author

RishabhJain2018 commented Mar 22, 2019

yeah, this seems to be correct. For the API part you might want to check the existing API's before creating a new one :)

@mahim23
Copy link

mahim23 commented Mar 22, 2019

@RishabhJain2018 So the closest API is change_submission_data_and_visibility which changes the submission data. But this API needs the user that requested it to be a participant of the team that made the submission. This is not the case in this feature/issue. So I've created a new API named change_submission_status. Is that fine?

@stale
Copy link

stale bot commented Jun 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactivity label Jun 8, 2019
@stale
Copy link

stale bot commented Jun 15, 2019

This issue has been automatically closed as there is no further activity. Thank you for your contributions.

@stale stale bot closed this as completed Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment