Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the download submission file url in challenge controller. #1168

Merged
merged 2 commits into from Aug 14, 2017
Merged

Fix the download submission file url in challenge controller. #1168

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32a858a
Fix the download submission file url in challenge controller.
RishabhJain2018 Aug 11, 2017
2b9d25b
Merge branch 'master' into url-fix
taranjeet Aug 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/js/controllers/challengeCtrl.js
View file
Open in desktop
Expand Up @@ -961,7 +961,7 @@
vm.downloadChallengeSubmissions = function() {
if(vm.phaseId) {
var parameters = {};
parameters.url = "challenges/"+ vm.challengeId + "/phase/" + vm.phaseId + "/download_all_submissions_file/" + vm.fileSelected + "/";
parameters.url = "challenges/"+ vm.challengeId + "/phase/" + vm.phaseId + "/download_all_submissions/" + vm.fileSelected + "/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing here the reason for this change. @RishabhJain2018 can you please point me out ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, actually during review @deshraj suggested me to change the endpoint but I forgot to update in the controller. That's why the feature isn't working.
Please refer here

parameters.method = "GET";
parameters.token = userKey;
parameters.callback = {
Expand Down