Fix #1641: add tests for challenge creation using zip file #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deshraj
requested changes
May 2, 2018
tests/unit/challenges/test_views.py
Outdated
| self.url = reverse_lazy('challenges:create_challenge_using_zip_file', | ||
| kwargs={'challenge_host_team_pk': self.challenge_host_team.pk}) | ||
|
|
||
| assert Challenge.objects.count() == 1 |
There was a problem hiding this comment.
Instead of this, please use self.assertEqual(Challenge.objects.count(), 1). Please do the same changes for other assert statements as well.
lenniezelk
force-pushed
the
add-upload-zip-challenge-tests
branch
from
6f3c998
to
116ae58
Compare
|
updated @deshraj |
|
any feedback @deshraj @RishabhJain2018 ? |
deshraj
approved these changes
May 14, 2018
deshraj
pushed a commit
that referenced
this pull request
Oct 24, 2018
HargovindArora
pushed a commit
to HargovindArora/EvalAI
that referenced
this pull request
Nov 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1641