Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2194: Added Total Participants in Analysis Page in a Challenge #2196

Merged
merged 5 commits into from
Mar 16, 2019
Merged

Fix #2194: Added Total Participants in Analysis Page in a Challenge #2196

merged 5 commits into from
Mar 16, 2019

Conversation

krtkvrm
Copy link
Member

@krtkvrm krtkvrm commented Mar 15, 2019 •
edited
Loading

Fix: #2196

Added Total Participants in Analysis Page in a Challenge

Screenshot from 2019-03-15 22-21-58

RishabhJain2018
RishabhJain2018 requested changes Mar 15, 2019
View reviewed changes
Copy link
Member

@RishabhJain2018 RishabhJain2018 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2019-03-15 at 12 59 31 PM
Can we please display it like this.

frontend/src/views/web/analytics/host-analytics.html Outdated Show resolved Hide resolved
@krtkvrm
Copy link
Member Author

krtkvrm commented Mar 15, 2019 •
edited
Loading

@RishabhJain2018
Screenshot from 2019-03-16 00-32-01

RishabhJain2018
RishabhJain2018 approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@RishabhJain2018 RishabhJain2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix @vkartik97

@deshraj deshraj merged commit c2f4627 into Cloud-CV:master Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RishabhJain2018 RishabhJain2018 RishabhJain2018 approved these changes

Assignees
No one assigned
Labels
can-be-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krtkvrm @RishabhJain2018 @deshraj