-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix team filter on All submissions page #3424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Issue] Tho we are able to show consistent data to the users but we aren't avoiding the redundant api calls which we could have achieved using switchMap
@gautamjajoo
\cc @Ram81
...pp/components/challenge/challengeviewallsubmissions/challengeviewallsubmissions.component.ts
Outdated
Show resolved
Hide resolved
...pp/components/challenge/challengeviewallsubmissions/challengeviewallsubmissions.component.ts
Outdated
Show resolved
Hide resolved
...pp/components/challenge/challengeviewallsubmissions/challengeviewallsubmissions.component.ts
Show resolved
Hide resolved
...pp/components/challenge/challengeviewallsubmissions/challengeviewallsubmissions.component.ts
Outdated
Show resolved
Hide resolved
...pp/components/challenge/challengeviewallsubmissions/challengeviewallsubmissions.component.ts
Outdated
Show resolved
Hide resolved
@Ram81 @Kajol-Kumari Reverted back the changes. We are now ignoring the previous API calls. Also, added it to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kajol-Kumari could you test this locally once
/** | ||
*Check whether team name is filtered | ||
*/ | ||
isTeamFiltered: boolean = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gautamjajoo the logic is not clear to me. Is this flag used to check if the query matches what we passed as parameter to filter API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, basically the pagination number is taken from the URL and when we filter the team name, the URL changes as well, hence we use this flag to check if there is a filter added then we change our URL to a different one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Problem: When we filter the team name on all submission page, the data is different than expected. It is because whichever api call is taking the most time that is being displayed on the page.
Fix:
filter.3.mp4
@RishabhJain2018 @Ram81 @Kajol-Kumari