-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add edit overview to settings tab #3462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gautamjajoo we should create a section for editing description of each page. You can create a new section named Edit description
and list all pages there
- Overview
- Evaluation criteria
- Terms and conditions
- Leaderboard
- Phases (this will include editing all phase details except upload phase annotations. Uploading annotations will go in next section)
Section for uploading evaluation script zip and phase annotations will come under Evaluation and Annotations
@Kajol-Kumari can you review this PR and test it locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gautamjajoo the edit feature is working fine. But can we please keep this edit text Challenge overview
just below the challenge title?
<div class="ev-action"> | ||
<div *ngIf="isChallengeHost" class="col-sm-1.5 col-xs-1.5 ev-upload-action"> | ||
<span class="fs-16 fw-light"> | ||
<strong class="text-light-black">Overview: </strong> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please make it Challenge overview
instead of Overview:
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are moving all the edit details to the new card #3451 (comment) so I will add the overview
in the Edit Description
card once that PR is approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since, we are not adding the new section, I will move the Challenge overview
just under the challenge title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gautamjajoo minor change required, rest LGTM 👍
</a> | ||
</div> | ||
</div> | ||
<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this as it's leading to an extra line gap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Added the edit overview to the
settings
tab under the edit challenge card.@Ram81 @Kajol-Kumari