Fix console error of change in expression value

[gautamjajoo]

Fix the error that occurs in dev mode when the change detection run twice.

Before

After
No error in console.

@Ram81 @Kajol-Kumari

[codecov-commenter]

Codecov Report

Merging #3550 (c6ece7b) into master (96968d6) will decrease coverage by 1.45%.
The diff coverage is 32.43%.

@@            Coverage Diff             @@
##           master    #3550      +/-   ##
==========================================
- Coverage   72.93%   71.47%   -1.46%     
==========================================
  Files          83       20      -63     
  Lines        5368     3232    -2136     
==========================================
- Hits         3915     2310    -1605     
+ Misses       1453      922     -531     

Impacted Files	Coverage Δ
frontend/src/js/controllers/authCtrl.js	53.91% <6.38%> (-12.95%)	⬇️
frontend/src/js/controllers/profileCtrl.js	79.76% <20.00%> (-13.10%)	⬇️
frontend/src/js/controllers/permissionCtrl.js	36.36% <22.22%> (-63.64%)	⬇️
frontend/src/js/controllers/challengeCtrl.js	63.41% <30.64%> (-10.29%)	⬇️
frontend/src/js/controllers/updateProfileCtrl.js	82.55% <44.44%> (-10.30%)	⬇️
frontend/src/js/controllers/challengeListCtrl.js	95.74% <50.00%> (+1.06%)	⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js	70.50% <66.66%> (-1.18%)	⬇️
frontend/src/js/controllers/teamsCtrl.js	71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js	100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js	95.45% <100.00%> (ø)
... and 30 more

Impacted Files	Coverage Δ
frontend/src/js/controllers/authCtrl.js	53.91% <6.38%> (-12.95%)	⬇️
frontend/src/js/controllers/profileCtrl.js	79.76% <20.00%> (-13.10%)	⬇️
frontend/src/js/controllers/permissionCtrl.js	36.36% <22.22%> (-63.64%)	⬇️
frontend/src/js/controllers/challengeCtrl.js	63.41% <30.64%> (-10.29%)	⬇️
frontend/src/js/controllers/updateProfileCtrl.js	82.55% <44.44%> (-10.30%)	⬇️
frontend/src/js/controllers/challengeListCtrl.js	95.74% <50.00%> (+1.06%)	⬆️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js	70.50% <66.66%> (-1.18%)	⬇️
frontend/src/js/controllers/teamsCtrl.js	71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js	100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js	95.45% <100.00%> (ø)
... and 30 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b05b5...c6ece7b. Read the comment docs.

[Kajol-Kumari]

@gautamjajoo as you have introduced the isAuth variable. Let's use this variable only at here

Rest LGTM 👍

[gautamjajoo]

@Kajol-Kumari I have not replaced it because first the value is false that's why the page is distorted when it is loading and then the value becomes true.

[Kajol-Kumari]

@Kajol-Kumari I have not replaced it because first the value is false that's why the page is distorted when it is loading and then the value becomes true.

yes @gautamjajoo but now as we are using detectChanges() so it's totally fine to use the isAuth variable in the html file

[gautamjajoo]

Actually, before opening the PR I tried to replace with the variable but the page is like this

[Kajol-Kumari]

Actually, before opening the PR I tried to replace with the variable but the page is like this

That's weird as It shouldn't happen ideally. Also, I tried doing the change on my local and it seems to work fine for me. Can you please try testing it again by replacing authService.isAuth with isAuth throughout the publiclist component html file? @gautamjajoo

[gautamjajoo]

@Kajol-Kumari I did change all the variables. I believe there is some issue with the changing values. Would it be better if we keep it same as authService.isAuth and consistent with other pages?

[Kajol-Kumari]

@Kajol-Kumari I did change all the variables. I believe there is some issue with the changing values. Would it be better if we keep it same as authService.isAuth and consistent with other pages?

yeah, we can keep this as this doing the same work but we need to figure out the reason behind it.

[gautamjajoo]

@Kajol-Kumari Replaced with isAuth variable, now assigning the value upon component initialization as well.

[Kajol-Kumari]

@gautamjajoo please format the comment for ngAfterViewChecked [The one line gap should be before comment, not after]

Rest, LGTM 👍

[gautamjajoo]

@Kajol-Kumari Done the changes!

[Ram81]

@gautamjajoo can you resolve the merge conflicts

[gautamjajoo]

@Ram81 Resolved the merge conflicts!

[Ram81]

LGTM