Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove submission count api call from submissions page #3562

Merged
merged 3 commits into from
Aug 5, 2021
Merged

Remove submission count api call from submissions page #3562

merged 3 commits into from
Aug 5, 2021

Conversation

gautamjajoo
Copy link
Member

@gautamjajoo gautamjajoo commented Aug 2, 2021 •
edited
Loading

Fixes the following points:

  • submissionCount in the allSubmissions page was giving the count of number of submissions of the participant team not all Submissions.
  • We don't require any API call for getting the count of submissions for a particular phase, the count is already there while we fetch the submissions.

@Ram81 @Kajol-Kumari

Kajol-Kumari
Kajol-Kumari approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@RishabhJain2018 RishabhJain2018 merged commit 7116eb1 into Cloud-CV:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RishabhJain2018 RishabhJain2018 RishabhJain2018 approved these changes

@Kajol-Kumari Kajol-Kumari Kajol-Kumari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gautamjajoo @RishabhJain2018 @Kajol-Kumari