Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch last 1000 lines of logs from the last 72 hours - submission worker #3832

Merged
merged 6 commits into from
Dec 6, 2022

Conversation

gchhablani
Copy link
Collaborator

This PR attempts to address the issue of losing the logs beyond last 15 minutes. Here, we try to fetch the logs for the last 10 events in the past 72 hours.

Please let me know what you think.

@Ram81

@gchhablani gchhablani marked this pull request as ready for review November 16, 2022 17:54
@gchhablani gchhablani changed the title Fetch last 10 event logs from the last 72 hours Fetch last 1000 lines of logs from the last 72 hours - submission worker Nov 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Merging #3832 (92b48b6) into master (96968d6) will decrease coverage by 1.34%.
The diff coverage is 34.87%.

@@            Coverage Diff             @@
##           master    #3832      +/-   ##
==========================================
- Coverage   72.93%   71.59%   -1.35%     
==========================================
  Files          83       20      -63     
  Lines        5368     3242    -2126     
==========================================
- Hits         3915     2321    -1594     
+ Misses       1453      921     -532     
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 63.59% <32.16%> (-10.11%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/profileCtrl.js 80.89% <45.45%> (-11.96%) ⬇️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/challengeListCtrl.js 95.74% <80.00%> (+1.06%) ⬆️
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 69 more
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) ⬇️
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) ⬇️
frontend/src/js/controllers/challengeCtrl.js 63.59% <32.16%> (-10.11%) ⬇️
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) ⬇️
frontend/src/js/controllers/profileCtrl.js 80.89% <45.45%> (-11.96%) ⬇️
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/challengeListCtrl.js 95.74% <80.00%> (+1.06%) ⬆️
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc3596...92b48b6. Read the comment docs.

apps/challenges/views.py Outdated Show resolved Hide resolved
@gchhablani
Copy link
Collaborator Author

Added the change from review.

@Ram81 Ram81 merged commit 46ee733 into Cloud-CV:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants