Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Move to Python 3.8 #4239

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

gchhablani
Copy link
Collaborator

IMPORTANT NOTES (please read, then delete):

  • The PR title should start with "Fix #bugnum: " (if applicable), followed by a clear one-line present-tense summary of the changes introduced in the PR. For example: "Fix #bugnum: Introduce the first version of the collection editor.".

  • Please make sure to mention "#bugnum" somewhere in the description of the PR. This enables GitHub to link the PR to the corresponding bug.

Please also make sure to follow the style rules.

@codecov-commenter
Copy link

Codecov Report

Merging #4239 (7b1a325) into master (96968d6) will decrease coverage by 3.63%.
Report is 1091 commits behind head on master.
The diff coverage is 46.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4239      +/-   ##
==========================================
- Coverage   72.93%   69.30%   -3.63%     
==========================================
  Files          83       20      -63     
  Lines        5368     3574    -1794     
==========================================
- Hits         3915     2477    -1438     
+ Misses       1453     1097     -356     
Files Coverage Δ
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
frontend/src/js/controllers/analyticsCtrl.js 80.72% <ø> (ø)
frontend/src/js/controllers/changePwdCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/contactUsCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/dashCtrl.js 99.07% <100.00%> (+0.14%) ⬆️
...ontend/src/js/controllers/featuredChallengeCtrl.js 68.99% <100.00%> (ø)
frontend/src/js/controllers/hostedChallengeCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/webCtrl.js 90.90% <100.00%> (ø)
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
... and 7 more

... and 63 files with indirect coverage changes

Files Coverage Δ
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
frontend/src/js/controllers/analyticsCtrl.js 80.72% <ø> (ø)
frontend/src/js/controllers/changePwdCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/contactUsCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/dashCtrl.js 99.07% <100.00%> (+0.14%) ⬆️
...ontend/src/js/controllers/featuredChallengeCtrl.js 68.99% <100.00%> (ø)
frontend/src/js/controllers/hostedChallengeCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/webCtrl.js 90.90% <100.00%> (ø)
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) ⬇️
... and 7 more

... and 63 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de637c...7b1a325. Read the comment docs.

@gchhablani gchhablani merged commit 25c783c into Cloud-CV:master Dec 18, 2023
1 check passed
gchhablani added a commit that referenced this pull request Dec 20, 2023
gchhablani added a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants