Fix #4242: Updated Deploy and Pull scripts for TravisCI to report it as failed on issue #4276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Behaviour
Deploy and Pull Scripts should send exit code 1 when failure occurs
Actual Behaviour
From the example, deploy.sh script is sending exit code 0, which means success and Travis CI, in return make build successful.
Fix:
Deploy.sh: Create a function to check for AWS_ACCOUNT_ID, and this function will only be called for the cases which uses this variable, for others cases, it will not check for this value.
Pull.sh: if env is production/staging, and error occurs in build_and_push function, it exits with error code 1.