Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add ZF Net model to FabrikZoo(#105) #107

Closed
wants to merge 2 commits into from

Conversation

prakharchoudhary
Copy link

@prakharchoudhary prakharchoudhary commented Sep 24, 2017

@utsavgarg In reference to issue #105 I found ZF net to be a viable addition to the models. Hence, I am making this PR.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.754% when pulling 15651b1 on prakharchoudhary:ZFnet into d036beb on Cloud-CV:master.

@utsavgarg
Copy link
Contributor

@prakharchoudhary The prototxt does not load in Fabrik. Please test it on fabrik.cloudcv.org before submitting a PR.

@prakharchoudhary
Copy link
Author

@utsavgarg I found the prototxt file for ZF net using faster rcnn on the following link:
https://github.com/rbgirshick/py-faster-rcnn/blob/master/models/pascal_voc/ZF/faster_rcnn_end2end/train.prototxt
Can you please have a look as to why this prototxt file is being termed invalid?

@utsavgarg
Copy link
Contributor

utsavgarg commented Sep 26, 2017

@prakharchoudhary It is because that prototxt is using a custom layer SmoothL1Loss which is not part of the standard Caffe package.

@prakharchoudhary
Copy link
Author

prakharchoudhary commented Sep 26, 2017

@utsavgarg SmoothL1Loss is necessary for the fast rcnn based zf net model. So should we wait until Caffe provides support for this layer? Or maybe we can use the fast-rcnn fork of caffe (here at: https://github.com/rbgirshick/caffe-fast-rcnn) in place of the standard version.

@virajprabhu
Copy link
Contributor

@utsavgarg Is SmoothL1Loss not a Python layer?
@prakharchoudhary In general, I don't think switching to third-party Caffe forks to support custom layers is a great idea in the long run. Also, please remember to resolve conflicts before you submit a PR.

@utsavgarg
Copy link
Contributor

@virajprabhu No it's not a Python layer but a custom layer implemented in cpp/cuda.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.754% when pulling e7bab7a on prakharchoudhary:ZFnet into 36d4e5d on Cloud-CV:master.

@utsavgarg utsavgarg closed this Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants