Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to verify challenge config file locally. #170

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add option to verify challenge config file locally. #170

wants to merge 2 commits into from

Conversation

KhalidRmb
Copy link
Member

  • Add the option for the challenges command.
  • User has to pass the config file path and host team ID after logging in.

@KhalidRmb KhalidRmb mentioned this pull request Aug 21, 2019
Closed
@KhalidRmb
Copy link
Member Author

Goes with EvalAI #2430.
@RishabhJain2018 @Ram81 PTAL.

RishabhJain2018
RishabhJain2018 requested changes Oct 16, 2019
View reviewed changes
Copy link
Member

@RishabhJain2018 RishabhJain2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhalidRmb Please register the verify_challenge_config as a command in the evalai/main.py file.

RishabhJain2018
RishabhJain2018 requested changes Oct 16, 2019
View reviewed changes
evalai/utils/challenges.py Outdated
"""
Function to verify a challenge config file.
"""
url = "{}".format(get_host_url(), URLS.verify_challenge_config.value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an {} as you are stuffing two values in format.

evalai/utils/challenges.py Outdated

response = response.json()
response = json.loads(response)
for e in response:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change e to something meaningful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RishabhJain2018 RishabhJain2018 RishabhJain2018 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KhalidRmb @RishabhJain2018