check for raw["description"]["text"] for mc servers >= 1.9 #2
Conversation
| @@ -139,8 +139,13 @@ def __init__(self, raw): | |||
|
|
|||
| if "description" not in raw: | |||
| raise ValueError("Invalid status object (no 'description' value)") | |||
| self.description = raw["description"] | |||
| self.description_clean = re.sub(r'\u00A7.', '', raw["description"]) | |||
| if "text" not in raw["description"]: | |||
There was a problem hiding this comment.
Wouldn't this attempt to subscript the value if raw["description"] was a string that contained the word "text"? I think an explicit type check may be safer in this case
|
Thank you for making this! I think this is covered by #1 though (if it's merged). |
|
Upgraded to the latest version, this issue is still not fixed. .mcping is non-functional, and a long standing bug. .rekt get's merged in, and that spreads by default malicious links, but we can't seem to get .mcping fixes merged... that is strange... Is that what this project has become? a malicious IRC bot? |
|
@astrutt In honesty this IRC bot has not been the most supported, as none of the main contributors are working on this project anymore. I'm attempting to at least do what I can, but I do not have access to all the repositories (mainly I don't have write access to |
|
I appreciate your attention to it and fixing it.
If it's abandoned, we might as well abandon it as well. Being that
malicious modules creep into it now.. it presents more liability than
usefulness at this point. I'm still debating.
…On Wed, May 31, 2017 at 2:27 PM, David Ross ***@***.***> wrote:
@astrutt <https://github.com/astrutt> In honesty this IRC bot has not
been the most supported, as none of the main contributors are working on
this project anymore.
I'm attempting to at least do what I can, but I do not have access to all
the repositories (mainly I don't have write access to mcstatus), and I
don't have too much free time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALFImvdx4ROAZJv7MlrlhmToizZtFiW0ks5r_bEugaJpZM4NO1Nx>
.
--
Andrew Strutt
andrew.strutt@gmail.com
https://keybase.io/astrutt
GV# : +1.702.514.0650
AF# : +93.07962.80801
|
|
Yeah, it's unfortunate. I can't really make that decision for you, I mean I'll support it as much as I can but that's not much. The other contributors that are semi-active now may be more available, but I don't believe there's anyone really providing full support for this. I do apologies for the rekt urls, that was entirely my fault. |
|
@astrutt There are several forks of CloudBot that are actively developed and maintained. Because @lukeroge was the original project owner those of us on the CloudBot development team have opted to maintain a steady state rather than introduce lots of new features that some of the other forks have implemented that may or may not fall outside of the scope of the original CloudBot. |
|
Well I appreciate you guys maintaining it, one of the best features we
liked was the minecraft modules.
Can that get fixed?
On Jun 4, 2017 17:44, "Andy Edwards" <notifications@github.com> wrote:
@astrutt <https://github.com/astrutt> There are several forks of CloudBot
that are actively developed and maintained. Because @lukeroge
<https://github.com/lukeroge> was the original project owner those of us on
the CloudBot development team have opted to maintain a steady state rather
than introduce lots of new features that some of the other forks have
implemented that may or may not fall outside of the scope of the original
CloudBot.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ALFImtHFdL-sJIeDyhUpqD4K_E-ZiDiTks5sAyUwgaJpZM4NO1Nx>
.
|
|
I don't think any of the current maintainers have write access to the CloudBotIRC/mcstatus repo. You can however either fork the repo and add the fix yourself then update the CloudBot requirements.txt file to point to your fork, or you can change your requirements.txt file to point to my fork which has the fix. replace https://github.com/CloudBotIRC/CloudBot/blob/master/requirements.txt#L3 Of course this isn't the best solution but hopefully it will help. |
No description provided.