Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate velocity secret when creating new velocity templates #1355

Merged
merged 11 commits into from
Feb 25, 2024

Conversation

0utplay
Copy link
Member

@0utplay 0utplay commented Feb 25, 2024

Motivation

Velocity requires us to create "forwarding.secret" file inorder to start the proxy.

Modification

Made sure that we create the forwarding secret when preparing a template.

Result

The "forwarding.secret" file is created when creating velocity templates.

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code t: fix A pull request introducing a fix for a bug. labels Feb 25, 2024
@0utplay 0utplay added this to the 4.0.0-RC10 milestone Feb 25, 2024
@0utplay 0utplay self-assigned this Feb 25, 2024
@derklaro derklaro merged commit d13c5c3 into nightly Feb 25, 2024
6 checks passed
@derklaro derklaro deleted the velocity-secret branch February 25, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: node An issue/pull request releated to the node module code t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants