-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow full customization of runner images and periodically update them #47
Conversation
…te them Build images in AWS using CodeBuild (or any user configured method) so that: 1. We can automatically update images on a schedule to get the latest runner version and latest OS updates. 2. We can build any type of image independent of the deployment platform. This will make it easy to provide Windows or ARM images (closes #7). 3. We can expose an interface allowing the user to easily modify the Docker images by adding packages or commands to the build process (closes #26). BREAKING CHANGE: providers no longer take runner version directly
Signed-off-by: github-actions <github-actions@github.com>
See the updated readme for usage. |
Would it be more obvious to have a matching provider label for // create a custom CodeBuild provider
const myProvider = new CodeBuildRunner(this, 'codebuild runner', {
label: 'codebuild-x64',
...
});
// grant some permissions to the provider
...
// create the runner infrastructure
new GitHubRunners(this, 'runners', {
providers: [codebuild-x64],
}); I'm just suggesting it because there may be people copying from the readme and not seeing their workers running because the labels don't match when they run their workflow against Again, it's just a suggestion 🤷 |
That's a good point. I keep forgetting to add proper workflow example. |
great commit, it's definitely more readable now, thanks for all the work 👍 |
Build images in AWS using CodeBuild (or any user configured method) so that:
BREAKING CHANGE: providers no longer take runner version directly