Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating API #82

Closed
ricky-lim opened this issue Oct 25, 2023 · 1 comment · Fixed by #84
Closed

Deprecating API #82

ricky-lim opened this issue Oct 25, 2023 · 1 comment · Fixed by #84

Comments

@ricky-lim
Copy link

[WARNING] aws-cdk-lib.aws_ec2.SubnetType#PRIVATE_WITH_NAT is deprecated.
use PRIVATE_WITH_EGRESS
This API will be removed in the next major release.
[WARNING] aws-cdk-lib.aws_ec2.SubnetType#PRIVATE_WITH_NAT is deprecated.
use PRIVATE_WITH_EGRESS
This API will be removed in the next major release.
[WARNING] aws-cdk-lib.aws_stepfunctions.StateMachineProps#definition is deprecated.
use definitionBody: DefinitionBody.fromChainable()
This API will be removed in the next major release.
[WARNING] aws-cdk-lib.aws_stepfunctions.StateMachineProps#definition is deprecated.
use definitionBody: DefinitionBody.fromChainable()
This API will be removed in the next major release.
@kichik
Copy link
Member

kichik commented Oct 25, 2023

SubnetType#PRIVATE_WITH_NAT was deprecated with PR #21699 and CDK v2.41.0. StateMachineProps#definition was deprecated with PR #25932 and CDK v2.85.0.

We still support CDK v2.0.0. We can't stop using those until we stop supporting older versions of CDK v2.

kichik added a commit that referenced this issue Oct 31, 2023
@kichik
fix: Remove deprecated CDK usage
766ffc2 
Fixes #82
@kichik kichik mentioned this issue Oct 31, 2023
Merged
@mergify mergify bot closed this as completed in #84 Oct 31, 2023
mergify bot pushed a commit that referenced this issue Oct 31, 2023
@kichik
fix: Remove deprecated CDK usage (#84)
494bb30 
Fixes #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove deprecated CDK usage CloudSnorkel/cdk-rds-sanitized-snapshots
2 participants
@kichik @ricky-lim