Block damaged items duplication #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What dupes exactly does it fix? |
This should fix all dupes which are caused by damaged item set back even the original item is not in the inventory anymore ("thorns dupe" and "crystal dupe" for example) |
|
Hm but what exactly leads to a dupe? useItemOn() returns the same Item after processing the interaction. Or how is that related to thorns or crystal? |
You kill yourself when the item is damaged and you get it back to your inventory (duplicated) even the inventory contents are already dropped |
|
So @Creeperface01 you ok with this or do you have better ideas? |
SupremeMortal
approved these changes
Aug 5, 2021
wode490390
pushed a commit
to NetEasePE/Nukkit
that referenced
this pull request
Dec 26, 2021
* Block damaged items duplication * Update Player.java (cherry picked from commit d063058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be better ways to fix this but this patches #1483 and other dupes by the same cause for now
(Fix #1483)