Fix health regen + hunger falling when food is disabled #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillQizza
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pull request is to implement health regeneration for difficulties above peaceful. (and also prevents a health desync between the client and server) This fixes #1855
Additionally, the issue #1859 is dependent on this pull request and the 2 are closely related. This pull request also updates hunger values and changes when food data is sent to the client in order to handle the hunger desync.
Food data is sent on all changes to saturation as the client appears to lose hunger (without attributes being sent) despite having saturation.
If food is disabled, food data is sent when the player should usually lose hunger in order to force it back to the max.
(Updated hunger values were pulled from https://minecraft.gamepedia.com/Hunger#Exhaustion_level_increase)