Explosion improvements #1908
Draft
Explosion improvements #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First issue
When an explosion is created by an end crystal entity over an indestructible (by explosion) block such as bedrock/obsidian, blocks aren't destroyed on the same y-level & below as the block (bedrock/obsidian) the end crystal was placed on which is behaviour from Minecraft Java Edition. Here is a video detailing vanilla bedrock edition 1.17.40 behaviour and the changes of this pull request here.
Second issue
Currently in Cloudburst Nukkit, there is no entity exposure taken into account for damage taken from an explosion. Details of entity exposure can be found here.
To fix/implement