Link to DBus and systemd #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the feature/modular branch usable? I would be happy to help making this happen. |
|
feature/modular is bit of behind, and not in usable state. I suggest packaging with the patch until implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBus and systemd were not linked are compile time. Now they are.
In most cases, wlc works without this change, but it's because if DBus and systemd were found, it usually means that the linker will be able to find them at runtime.
This is not the case on the NixOs Linux distribution, which clears LD_LIBRARY_PATH after building and solely uses the binairies and libraries' RPATH to find the dynamic libraries. If a library is not linked at compile time (although still dynamically linked and not statically linked), the RPATH is not properly written.