Re-sync of contacts

[sumairasaeed]

We need to re-sync contacts if we make any change in addressbook. This code logic is currently commented out in code

[jekram]

OK. Show me the current design and the design before it was commented out?

[sumairasaeed]

In current design, contact list of Kibo chat gets synced only once at the time of installation process. If there is any change in device phonebook after installation,no change is reflected in KiboChat App. Here is a logical flow which shows the steps performed for contacts sync during installation:

The logic for syncing contacts after installation is currently commented out in code. Here is a design for commented out logic. If the app was in background, and there was a change in device phonebook(e.g. contact added,edited/deleted) , a notification is fired when we come back to app screen.

Here is the flow of contact sync service which runs when notification is fired:

If app was closed at the time there was change in device phonebook, then no notification is triggered. We can have a "Refresh" button on app to cover this case.

[jekram]

What was the issue that caused us to comment it out? What is the effort to turn it on and test it?

[sumairasaeed]

It was commented out when we were having performance issues with large addressbook. Effort to turn it ON and test it is minimal.

[jekram]

OK. Let's do this

[sumairasaeed]

Uncommented and pushed the code. Tested and found it has some bug. Contacts gets sunced and UI correctly updates sometimes while sometimes it does not get updated correctly. I am looking into this issue.

…

On Tue, Dec 27, 2016 at 10:34 AM, Cloudkibo ***@***.***> wrote: OK. Let's do this — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#463 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKbhpyxN_tbUhjLp4QywGtZ3OmXz9h-oks5rMKNugaJpZM4LVsjh> .

[jekram]

What else is new? Always leaving work incomplete.

Under what circumstances it did not worked?

[jekram]

Once this is fixed it needs to be published

[sumairasaeed]

acknowledged

…

On Thu, Dec 29, 2016 at 12:54 PM, Cloudkibo ***@***.***> wrote: Once this is fixed it needs to be published — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#463 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKbhp8x55DXeXKWm8GNpKhTCo73QEawJks5rM2cygaJpZM4LVsjh> .

[sumairasaeed]

Working on it. Debugged through breakpoints and logs. The notification for change in phonebook is being fired more than once. There is then clash when updating database. Trying to fix it.

[sumairasaeed]

I have fixed the bug. Doing some testing and then will push the application in a while IA

[jekram]

Push it on both the place

[sumairasaeed]

This task has been completed. Push to test flight is in progress. Once it completes processing, we can then push it to marketplace.
If app was running, contact list will get updated by itself.
If the application was closed when phonebook got changed, we can refresh contact list using "Refresh" button on Contacts tab as shown:

[sumairasaeed]

Pushed to Test flight and market place. Status of marketplace is "Waiting for Review"