Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(File attachment) Sender should be able to see what contact was sent. #537

Closed
sumairasaeed opened this issue Mar 16, 2017 · 9 comments
Closed

Comments

@sumairasaeed
Copy link
Contributor

When sharing contact, contact should be clickable and display details as whatsapp:
image

@jekram
Copy link
Contributor

jekram commented Mar 16, 2017

why now? do we not understand what we had to do in the first place.

@sumairasaeed
Copy link
Contributor Author

Worked on this. It now displays details when we tap on contact. Need to add "Create Contact" button

@sumairasaeed
Copy link
Contributor Author

Also WatsApp has buttons for "Invite to WatsApp" and "Message" when contact is shared.
Will also implement these as part of this task:
image

@sumairasaeed
Copy link
Contributor Author

I have worked and completed the UI work for this but this will need some server side work to code the functionality. I have discussed this with @sojharo and opened required task on server Cloudkibo/CloudKibo#507

@jekram
Copy link
Contributor

jekram commented Mar 30, 2017

@sumairasaeed @sojharo
I do not understand this.

  1. We bring all the contacts on the initial install. When a new contact is a added to address book do we not add them into KiboChat ?

  2. When somebody was not using KiboChat and start using it I thought it is reflected in KiboChat address book.

  3. If the the above establish socket.io connection and join rooms #1 and # 2 are true then you ask is redundant.

@sumairasaeed
Copy link
Contributor Author

We bring all the contacts on the initial install. When a new contact is a added to address book do we not add them into KiboChat ?

Ans: Yes sir we do.

When somebody was not using KiboChat and start using it I thought it is reflected in KiboChat address book.

Ans: Currently it is not reflected.

If the the above #1 and # 2 are true then you ask is redundant.

Ans: This is the case when we receive a contact shared by other user. That contact can be in our addressbook already and cannot be. That contact could be the one registered on KiboChat and could be the one not using KiboChat. We have to display buttons accordingly. But for that we must get this information from server whether the contact is registered on kibochat or not. If not, we will display option to "Invite to KiboChat".

@jekram
Copy link
Contributor

jekram commented Mar 31, 2017

@sumairasaeed

Thanks for the update.

If we not doing #2 then we should do #2 and open a bug. If #1 & #2 are done then we do not need to fix this.

@sojharo
Copy link
Contributor

sojharo commented Mar 31, 2017

I have seen the server side task. The one way we were doing no 2 was if I get message from somebody who is shown not on cloudkibo in my address book then we should update him on the address book to be shown as on cloudkibo. From server side, I can send a push notification when a user joins cloudkibo.

@sumairasaeed
Copy link
Contributor Author

This has been completed now
screen shot 2017-04-11 at 12 12 05 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants