Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Contact shows incorrect buttons #621

Closed
sumairasaeed opened this issue May 18, 2017 · 3 comments
Closed

Shared Contact shows incorrect buttons #621

sumairasaeed opened this issue May 18, 2017 · 3 comments

Comments

@sumairasaeed
Copy link
Contributor

sumairasaeed commented May 18, 2017

Wrong buttons are displayed when contact is shared. Contact was not on cloudkibo so it should show 'invite' button on sender's side.
Also, there should be 'save' button on receiving side which is missing.
Here are screenshots:

Receiver's screen ----------------------------------------------------Sender's screen:

screen shot 2017-05-18 at 6 23 20 pm

@sumairasaeed sumairasaeed changed the title Share Contact Options incorrect on sender's side Shared Contact shows incorrect buttons May 18, 2017
@jekram
Copy link
Contributor

jekram commented May 18, 2017

What was the task that created this?

Did it ever worked or it is broken now?

@jekram jekram added the Medium label May 18, 2017
@sumairasaeed
Copy link
Contributor Author

This task created this: #537
Senders side didnot work. Buttons were correctly shown on receiving end.
This has been fixed now.

@jekram
Copy link
Contributor

jekram commented May 22, 2017

So in task #537 we had not throughly tested it? it is not ok to close a task without testing it. Just trying to understand it was working then and it broke later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants