Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLOC-4557] Bind mount /dev into the lsblk test container #2977

Merged
merged 1 commit into from
Dec 16, 2016

Conversation

wallrj
Copy link
Contributor

@wallrj wallrj commented Dec 15, 2016

Fixes:

Bind mount /dev into the lsblk test container so that multi-path devices can be examined.

@shay-berman please test this modified version of the acceptance test with your IBM driver.

I dug into the Docker and runc code to understand how /dev gets populated inside the container.
See the comments and links in the patch.

@shay-berman
Copy link

I just planned to push that fix to the project(for my first flocker contribution) but you did that first :-)

@wallrj
Copy link
Contributor Author

wallrj commented Dec 15, 2016

See moby/moby#16160 for more discussion of why /dev inside the container does not have all the devices that are available on the host server.

@wallrj wallrj merged commit ca0cb51 into master Dec 16, 2016
@wallrj wallrj deleted the FLOC-4557-dev-mapper-blockdevice-size branch December 16, 2016 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants