Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crm node delete should adopt most of functionalities of crm cluster remove as mentioned in PR890 #891

Closed
zzhou1 opened this issue Nov 26, 2021 · 0 comments · Fixed by #1090

Comments

@zzhou1
Copy link
Contributor

zzhou1 commented Nov 26, 2021

Probably this is low priority. Not likely many user use this interface.

crm cluster remove tw3 works nicely so far.
Well, I expect the following alternative will do the same job. crm node delete tw3

Do you mean crm cluster remove <node> and crm node delete share the same code functions and execute the the process? Then we need another PR to do this

If the code can be reused directly, that will be great. From the behavior wise, crm node delete <node> should adjust_pcmk_delay_max here. Maybe, most of other behavior should be the same too.

Or, create it as an alias of "crm cluster remove"

Or, deprecate crm node delete, and eventually drop it?

Originally posted by @zzhou1 in #890 (comment)

nicholasyang2022 added a commit to nicholasyang2022/crmsh that referenced this issue Dec 13, 2022
It will also stop cluster services and adjust related pacemaker configs.

Close ClusterLabs#891.
nicholasyang2022 added a commit to nicholasyang2022/crmsh that referenced this issue Dec 13, 2022
It will also stop cluster services and adjust related pacemaker configs.

Close ClusterLabs#891.
nicholasyang2022 added a commit to nicholasyang2022/crmsh that referenced this issue Dec 14, 2022
It will also adjust the related cluster configurations and clean up the
leftover (eg. stopping the cluster services) on the removed node.

Close ClusterLabs#891.
nicholasyang2022 added a commit to nicholasyang2022/crmsh that referenced this issue Dec 15, 2022
It will also adjust the related cluster configurations and clean up the
leftover (eg. stopping the cluster services) on the removed node.

Close ClusterLabs#891.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant