[crmsh-4.6] Unify version definition #1280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 version strings used in crmsh:
setup.py
. It was hardcoded insetup.py
../version
, which will be installed to/usr/shar/crmsh/version
, used bycrm --version
. It was hardcoded inAC_INIT
macro inconfigure.ac
.This pull request contains 2 changes:
setup.py
read version from./version
, so that the version string is unified between python package metadata andcrm --version
.--with-version
option in autoconf, so that it can override the version string in generated./version
file. This allow a packager to override the version string.With these change, a packager can use
git describe
and./configure --with-version
to generate version string automatically from git tags.