-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev: corosync: add subcommands 'crm corosync link ...' for managing multi-links in knet (jsc#PED-8083) #1471
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
8fb8600
to
255f49c
Compare
|
Should complaint when assigning the same IP |
|
ba0a473
to
24777f7
Compare
I think the showing order should be
|
After adding link twice:
Please put the ring 0-2 together |
This case should raise an error and show the usage? |
24777f7
to
11d1d42
Compare
This is syntactically correct according to the usage. IMO it is better to exit successfully with a warning message. |
a0db49d
to
53fcbc3
Compare
|
When there are two or more links, remove the first link(index is 0) should be allowed |
53fcbc3
to
05a1dcc
Compare
Not fully work. As the help system does not support subcommands at 3rd-level. Apply suggestions from code review for docs Co-authored-by: Roger Zhou <zzhou@suse.com>
… when an not updatable option is specified
…D-8083) Both updating link options and adding/removing links are hot reloadable. Updating the address of existing nodes is not hot reloadable. Update crmsh/ui_corosync.py Co-authored-by: Roger Zhou <zzhou@suse.com> do not reload or restart if corosync.service is not running Co-authored-by: Roger Zhou <zzhou@suse.com>
… nodes (jsc#PED-8083)
6b19adc
to
2c07507
Compare
…luster (jsc#PED-8083)
We have some problem in the functional tests with
Here the whole
While
|
A guess work, maybe corosync link state is still transitioning, maybe need wait a little time for the stable state? |
Knet transport in corosync provides flexible configurations of multi-link connectivity. This pull request adds some subcommands to manage these configurations, including:
crm corosync link show
to list configured linkscrm corosync link update <linknumber> [<nodename>=<new_address> ... ] [options <option>=[value] ...]
to modify an existing linkcrm corosync link add <nodename>=<new_address> ... [options <option>=[value] ...]
to add a new link.crm corosync link remove <linknumber>
to remove an existing link.These subcommands operate on local configuration file
corosync.conf
. To make the changes to take effects, the configuration file needs to be synchronized across the cluster withcrm corosync push
and corosync service needs to be restarted.