Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.6] Dev: refine change detection for crm configure (#1466) #1487

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

nicholasyang2022
Copy link
Collaborator

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.48%. Comparing base (c76a2bd) to head (e720df0).

Additional details and impacted files
Flag Coverage Δ
integration 53.14% <69.23%> (+0.01%) ⬆️
unit 49.89% <23.07%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
crmsh/constants.py 100.00% <ø> (ø)
crmsh/ui_configure.py 43.83% <100.00%> (+0.11%) ⬆️
crmsh/xmlutil.py 69.10% <100.00%> (+0.24%) ⬆️
crmsh/cibconfig.py 63.21% <90.90%> (+0.03%) ⬆️
crmsh/ui_assist.py 24.70% <0.00%> (-0.30%) ⬇️
crmsh/ui_context.py 58.46% <71.42%> (+0.28%) ⬆️
crmsh/ui_maintenance.py 40.67% <0.00%> (-0.71%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 merged commit 00d2889 into ClusterLabs:crmsh-4.6 Jul 11, 2024
31 checks passed
@nicholasyang2022 nicholasyang2022 deleted the fix-1466-4.6 branch July 12, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants