-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection of patches for crmsh #77
Conversation
Alright, with that sorted I will merge this. Thanks both of you! |
Hmm. I noticed now that the transition patch broke the history test case. It seems no transitions are found after applying this patch:
Is this a reason to revert the patch? |
On Thu, Jan 22, 2015 at 01:52:27AM -0800, Kristoffer Grönlund wrote:
Oops, that's not good.
Hmm, perhaps, I don't know, will take a look. |
On Thu, Jan 22, 2015 at 01:52:27AM -0800, Kristoffer Grönlund wrote:
The message format in this patch got introduced with this change: commit d13ce588e9fe4277d6570a54f0728223fe505627
...
Maybe something like this would do:
|
Updating with this regex fixes the history test case, not only that, it manages to discover an additional transition thanks to this change :) So this seems good now. |
With new transition regex, the partial transition number 47 is also detected and available.
With new transition regex, the partial transition number 47 is also detected and available.
No description provided.