Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSS-Fuzz integration #3466

Merged
merged 3 commits into from
May 28, 2024
Merged

OSS-Fuzz integration #3466

merged 3 commits into from
May 28, 2024

Conversation

DavidKorczynski
Copy link
Contributor

Adds OSS-Fuzz integration to enable continuous fuzzing of Pacemaker.

The corresponding PR on OSS-Fuzz is here: google/oss-fuzz#11978

@knet-jenkins knet-jenkins
Copy link

knet-jenkins bot commented May 20, 2024

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/pacemaker/job/pacemaker-pipeline/job/PR-3466/1/input

@DavidKorczynski
Copy link
Contributor Author

CC @AdamKorcz @kgaillot

@DavidKorczynski DavidKorczynski mentioned this pull request May 20, 2024
Merged
@DavidKorczynski
OSS-Fuzz integration
3bd1a50 
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski DavidKorczynski mentioned this pull request May 20, 2024
Merged
@DavidKorczynski
Copy link
Contributor Author

This will need some minor adjustments once #3467 is merged. I propose to land this only after #3467

kgaillot
kgaillot reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@kgaillot kgaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with OSS-Fuzz, so I can't speak to the appropriateness of the fuzzing, but this is my review of the code itself.

To parallel our unit testing, it might be better to create a separate fuzzers directory for each of our libraries being fuzzed (which in this case would be lib/common/fuzzers and lib/cib/fuzzers).

fuzzers/README.md Outdated Show resolved Hide resolved
fuzzers/cib_file_fuzzer.c Outdated Show resolved Hide resolved
fuzzers/cib_file_fuzzer.c Outdated Show resolved Hide resolved
fuzzers/cib_file_fuzzer.c Show resolved Hide resolved
fuzzers/cib_file_fuzzer.c Outdated Show resolved Hide resolved
fuzzers/strings_fuzzer.c Outdated Show resolved Hide resolved
fuzzers/strings_fuzzer.c Outdated Show resolved Hide resolved
fuzzers/strings_fuzzer.c Outdated Show resolved Hide resolved
fuzzers/utils_fuzzer.c Outdated Show resolved Hide resolved
fuzzers/utils_fuzzer.c Outdated Show resolved Hide resolved
@DavidKorczynski
Refactor: address review
1b4cc8c 
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski
Copy link
Contributor Author

@kgaillot thanks for the review, I have addressed all points

@knet-jenkins knet-jenkins
Copy link

knet-jenkins bot commented May 24, 2024

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/pacemaker/job/pacemaker-pipeline/job/PR-3466/2/input

kgaillot
kgaillot reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@kgaillot kgaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

fuzzers/iso8601_fuzzer.c Outdated Show resolved Hide resolved
@DavidKorczynski
remove unused conditional
bd558a9 
Signed-off-by: David Korczynski <david@adalogics.com>
@knet-jenkins knet-jenkins
Copy link

knet-jenkins bot commented May 28, 2024

Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/pacemaker/job/pacemaker-pipeline/job/PR-3466/3/input

kgaillot
kgaillot approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@kgaillot kgaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kgaillot kgaillot merged commit 359ac7a into ClusterLabs:main May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgaillot kgaillot kgaillot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidKorczynski @kgaillot