Refactor: pengine: Reschedule specific monitors when resource definitions have changed #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gao-yan
force-pushed
the
reschedule-specific-monitor
branch
from
d12eb33
to
d7797db
Compare
|
I'm confused... doesn't this reverse the commits you had me merge yesterday? |
|
Not actually. The idea of this commit is similar -- to record it in check_action_definition(), and only mark it as "required" in RecurringOp(). This one uses an optional monitor in check_action_definition(), utilizes the op flag instead of resource flag to record that -- I think it should be better to make that precise when it's possible. |
|
Ah, I see now. |
beekhof
added a commit
that referenced
this pull request
Mar 2, 2015
Refactor: pengine: Reschedule specific monitors when resource definitions have changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved memory leaks. Well, and refactored -- I think it's more precise to reschedule specific monitors ;-)