Minor stonith fixes and refactoring #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fencing regression tests and a 100-random-test run of CTS with broadcast, levels-or and levels-and fencing ran fine with this. |
|
Merge now? |
stonith_create_op() already adds the call options attribute to the operation XML, and then initiate_remote_stonith_op() was explicitly adding the attribute again. Now it passes the correct value to stonith_create_op() so it is added once.
…to fence This has no effect now but will be needed when reboot is remapped to off+on, and eligibility will need to be checked separately for off and on.
…es to XML This has no effect now but will be needed when reboot is remapped to off+on, and properties will need to be added separately for off and on.
…ies from XML This has no effect now but will be needed when reboot is remapped to off+on, and properties will need to be parsed separately for off and on.
This has no effect now but will be helpful when reboot is remapped to off+on, and device lists will need to take into account whether the device can execute off, on or both.
This renames the "devices" member to "ndevices" in st_query_result_t. It's a little easier to read since "devices" is often used in other contexts as a list or such, but the main reason is because it allows the current "device_list" member be renamed to "devices" if its implementation changes as planned for remapping reboot to off+on.
If a fence agent does not advertise support for reboots, the executing stonithd will remap the reboot to off at execution time. Previously, that meant the action-specific timeout for reboot had already been applied. Now, the remapping is checked when determining the timeout, as well as when executing.
|
When you asked, no -- now, yes :) |
|
@kgaillot these changes all look good to me. great work! |
davidvossel
added a commit
that referenced
this pull request
Jul 1, 2015
Minor stonith fixes and refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this includes a couple of minor fixes and some additional developer documentation, the main goal is to lay the groundwork for being able to remap reboot to off+on.