Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor stonith fixes and refactoring #742

Merged
merged 10 commits into from
Jul 1, 2015
Merged

Minor stonith fixes and refactoring #742

merged 10 commits into from
Jul 1, 2015

Commits on Jun 25, 2015

  1. doc: fencing: add README describing stonith request handling

    @kgaillot
    kgaillot committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    35a8bfc View commit details
    Browse the repository at this point in the history

  2. Fix: fencing: do not set call options twice in query 

    stonith_create_op() already adds the call options attribute to the operation
XML, and then initiate_remote_stonith_op() was explicitly adding the
attribute again. Now it passes the correct value to stonith_create_op()
so it is added once.
    @kgaillot
    kgaillot committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    cfa1446 View commit details
    Browse the repository at this point in the history

  3. Refactor: fencing: functionize testing whether localhost is eligible … 

    …to fence

This has no effect now but will be needed when reboot is remapped
to off+on, and eligibility will need to be checked separately for
off and on.
    @kgaillot
    kgaillot committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    8da2144 View commit details
    Browse the repository at this point in the history

  4. Refactor: fencing: functionize adding action-specific device properti… 

    …es to XML

This has no effect now but will be needed when reboot is remapped
to off+on, and properties will need to be added separately for
off and on.
    @kgaillot
    kgaillot committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    b8e120d View commit details
    Browse the repository at this point in the history

  5. Refactor: fencing: functionize parsing action-specific device propert… 

    …ies from XML

This has no effect now but will be needed when reboot is remapped
to off+on, and properties will need to be parsed separately for
off and on.
    @kgaillot
    kgaillot committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    2699f36 View commit details
    Browse the repository at this point in the history

  6. Refactor: fencing: isolate access to peers' device lists 

    This has no effect now but will be helpful when reboot is remapped
to off+on, and device lists will need to take into account whether
the device can execute off, on or both.
    @kgaillot
    kgaillot committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    07e8dec View commit details
    Browse the repository at this point in the history

  7. Refactor: fencing: make structure member name for device count clearer 

    This renames the "devices" member to "ndevices" in st_query_result_t.
It's a little easier to read since "devices" is often used in other contexts as
a list or such, but the main reason is because it allows the current
"device_list" member be renamed to "devices" if its implementation changes
as planned for remapping reboot to off+on.
    @kgaillot
    kgaillot committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    e0b0da3 View commit details
    Browse the repository at this point in the history

  8. Fix: fencing: use "off" timeout when remapping "reboot" to "off" 

    If a fence agent does not advertise support for reboots, the executing
stonithd will remap the reboot to off at execution time. Previously,
that meant the action-specific timeout for reboot had already been
applied. Now, the remapping is checked when determining the timeout,
as well as when executing.
    @kgaillot
    kgaillot committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    2a82a0a View commit details
    Browse the repository at this point in the history

  9. Refactor: fencing: improve comments and log messages

    @kgaillot
    kgaillot committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    30e93fb View commit details
    Browse the repository at this point in the history

  10. Fix: cts: handle clones when checking for resource failures

    @kgaillot
    kgaillot committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    5966ddb View commit details
    Browse the repository at this point in the history