LVM: status check for missing VG #981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renzhengeek
reviewed
Oct 16, 2017
| output=$(vgscan $vg 2>&1) | ||
| else | ||
| output=$(vgscan --cache 2>&1) | ||
| fi |
There was a problem hiding this comment.
I think 'vgscan --cache' is very expensive lvm command, especially if there are a large of LVs on system. LVM_status will be invoked periodically. I don't think it's good idea to ad it in status checking.
renzhengeek
reviewed
Oct 16, 2017
| fi | ||
| if ! echo "$output" | grep -q "Found.*\"$1\""; then | ||
| ocf_exit_reason "LVM Volume $1 is not available" | ||
| return $OCF_ERR_GENERIC |
There was a problem hiding this comment.
It seems to me that 'status action' expects either OCF_SUCESS or OCF_NOT_RUNNING...
|
From my perspective, in status action, it's always good to use short/quick code to accurately check the LV/VG activation status directly :) |
|
I think 'vgscan --cache' is very expensive lvm command, especially if there are a large of LVs on system. LVM_status will be invoked periodically. I don't think it's good idea to ad it in status checking.
Actually, _all_ lvm commands were at one point in time removed from the status action exactly because timeouts were reported. The timeouts were apparently also due to volumes unrelated to the cluster. Note that they were not even vgscan, but something looking very innocuous. There should be a thread somewhere on the linux-ha ML.
|
|
Thanks for your feedback. I agree, and will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect if VG is missing (e.g. for multipath where the device is still present when it's unavailable).