Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LVM: status check for missing VG #981

Closed
wants to merge 1 commit into from
Closed

LVM: status check for missing VG #981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions heartbeat/LVM
View file
Open in desktop
Expand Up @@ -320,6 +320,18 @@ LVM_status() {
fi
fi
fi

# Check if VG is still available (e.g. for multipath where the device
# doesn't disappear)
if [ "$LVM_MAJOR" -eq "1" ]; then
output=$(vgscan $vg 2>&1)
else
output=$(vgscan --cache 2>&1)
fi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 'vgscan --cache' is very expensive lvm command, especially if there are a large of LVs on system. LVM_status will be invoked periodically. I don't think it's good idea to ad it in status checking.

if ! echo "$output" | grep -q "Found.*\"$1\""; then
ocf_exit_reason "LVM Volume $1 is not available"
return $OCF_ERR_GENERIC
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that 'status action' expects either OCF_SUCESS or OCF_NOT_RUNNING...

fi

if [ -d /dev/$1 ]; then
test "`cd /dev/$1 && ls`" != ""
Expand Down