Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single vs multiple app mode in develop branch #1046

Closed
zferdana opened this issue Dec 12, 2017 · 7 comments
Closed

Single vs multiple app mode in develop branch #1046

zferdana opened this issue Dec 12, 2017 · 7 comments
Assignees

Comments

@zferdana
Copy link
Member

Casey - just want to make sure the develop branch can do both single and multiple app mode. I just tried --framework-branch=develop and got this:

screen shot 2017-12-11 at 4 59 14 pm

I had to deploy the master framework in order to produce the dev oceanwealth region. I suspect we will need both modes working well on the develop branch to test both the super app in Hawaii as well as the in-app print (Jacob will test on dev oceanwealth).

@zferdana zferdana added this to the Priority Bug Fixes milestone Dec 12, 2017
@caseycesari
Copy link
Contributor

@zferdana Hi Zach. The develop branch can do both single and multiple app mode. It is configured via the region.json. There is likely something else causing the above problem.

Can you provide the full build command you ran so that I can try and reproduce this locally?
Thanks.

@zferdana
Copy link
Member Author

Sure - I didn't change anything to region.json since I was building our traditional, multiple plugin framework mode.

build.py oceanwealth-region --prod --framework-branch=develop --region-branch=development

@caseycesari
Copy link
Contributor

@zferdana Can you try running the command again? I was able to reproduce the issue you were experiencing. I then merged CoastalResilienceNetwork/regional-planning#95 into master for regional planning (this is related to #1043), tried the build command again, and the site worked.

Thanks.

@matts5517
Copy link

Hey, I am also getting the same problem as above when building in Develop
my code:
build.py wisconsin-region FreshwaterNetwork --dev --framework-branch=develop --region-branch=development.

I want to use the legend single column functionality which i think is only under the develop branch for now?

Thanks,
Matt

My console:

screen shot 2018-01-03 at 12 30 22 pm

@caseycesari
Copy link
Contributor

Hi @matts5517,

I believe the error you reported is being caused by the regional-planning plugin, which is pinned at an old commit in the Wisconsin region. Take a look at https://github.com/FreshwaterNetwork/wisconsin-region/blob/b2e6e7fc5235cc959218e02dcde95904aaff3176/plugins.json#L6. That commit is from early 2017. If you update the version attribute to the latest commit, or drop the version attribute entirely, you'll get the latest version of regional-planning, which should fix this issue.

@matts5517
Copy link

Thanks, that fixed the issue, sorry about that.

-Matt

caseycesari added a commit that referenced this issue Jan 4, 2018
Adjust the use config to support all of the various ways that underscore
is imported within plugins.

The previous fix implemented in #1044 caused problems with plugins that
bring in their own version of underscore in via a CDN. The adjustments
here should make that possible while still allowing plugins to import
underscore via Use.js.

Also, rename the framework version of underscore to reduce confusion.

Refs #669, #1043, #1046
caseycesari added a commit that referenced this issue Jan 4, 2018
Adjust the use config to support all of the various ways that underscore
is imported within plugins.

The previous fix implemented in #1044 caused problems with plugins that
bring in their own version of underscore in via a CDN. The adjustments
here should make that possible while still allowing plugins to import
underscore via Use.js.

Also, rename the framework version of underscore to reduce confusion.

Refs #669, #1043, #1046
@caseycesari caseycesari self-assigned this Jan 4, 2018
@ajrobbins
Copy link

This issue was resolved by using the latest version of regional-planning. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants