Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local underscore import #95

Merged
merged 1 commit into from Dec 14, 2017
Merged

Conversation

caseycesari
Copy link
Contributor

@caseycesari caseycesari commented Dec 13, 2017

Overview

Issues referencing underscore in plugins was remedied in CoastalResilienceNetwork/GeositeFramework#669. Local imports of underscore are no longer needed and cause conflicts with the framework version of underscore when they exist.

Testing

  • Bring up an instance of the framework on develop, and add this plugin.
  • Ensure the plugin loads and layers can be added.

Issues referencing underscore in plugins was remedied in CoastalResilienceNetwork/GeositeFramework#669. Local imports of underscore are no longer needed.
@jwalgran
Copy link

Reviewing this now

@caseycesari
Copy link
Contributor Author

Thanks

Copy link

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replace my previous regional-planning plugin with this branch and was still able to load layers

screen shot 2017-12-14 at 11 31 28 am

@caseycesari
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants