Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Use ninja on appveyor #819

Merged
merged 1 commit into from Dec 2, 2019
Merged

Use ninja on appveyor #819

merged 1 commit into from Dec 2, 2019

Conversation

janisozaur
Copy link
Contributor

ninja is not only faster than msbuild, but also brings some sanity to
the messages produced by compiler: first, it holds a lock over output,
only allowing single process to write at once; second: it reduces
verbosity to something palatable.

msbuild:

  GraphViewStyle.cpp
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(148): warning C4244: '=': conversion from 'float' to 'int', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(319): warning C4244: '=': conversion from 'size_t' to 'float', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(319): warning C4244: '=': conversion from 'float' to 'int', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(335): warning C4244: '=': conversion from 'size_t' to 'float', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(335): warning C4244: '=': conversion from 'float' to 'int', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(360): warning C4244: '=': conversion from 'size_t' to 'float', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(360): warning C4244: '=': conversion from 'float' to 'int', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(621): warning C4244: '=': conversion from 'int' to 'float', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
  MainView.cpp
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(691): warning C4244: '=': conversion from 'int' to 'float', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(728): warning C4244: 'return': conversion from 'double' to 'int', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(733): warning C4244: 'return': conversion from 'double' to 'int', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]

ninja:

[244/398] Building CXX object CMakeFiles\Sourcetrail_lib.dir\src\lib\component\view\GraphViewStyle.cpp.obj
..\..\src\lib\component\view\GraphViewStyle.cpp(148): warning C4244: '=': conversion from 'float' to 'int', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(319): warning C4244: '=': conversion from 'size_t' to 'float', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(319): warning C4244: '=': conversion from 'float' to 'int', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(335): warning C4244: '=': conversion from 'size_t' to 'float', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(335): warning C4244: '=': conversion from 'float' to 'int', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(360): warning C4244: '=': conversion from 'size_t' to 'float', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(360): warning C4244: '=': conversion from 'float' to 'int', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(621): warning C4244: '=': conversion from 'int' to 'float', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(691): warning C4244: '=': conversion from 'int' to 'float', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(728): warning C4244: 'return': conversion from 'double' to 'int', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(733): warning C4244: 'return': conversion from 'double' to 'int', possible loss of data

ninja is not only faster than msbuild, but also brings some sanity to
the messages produced by compiler: first, it holds a lock over output,
only allowing single process to write at once; second: it reduces
verbosity to something palatable.

msbuild:
```
  GraphViewStyle.cpp
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(148): warning C4244: '=': conversion from 'float' to 'int', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(319): warning C4244: '=': conversion from 'size_t' to 'float', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(319): warning C4244: '=': conversion from 'float' to 'int', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(335): warning C4244: '=': conversion from 'size_t' to 'float', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(335): warning C4244: '=': conversion from 'float' to 'int', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(360): warning C4244: '=': conversion from 'size_t' to 'float', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(360): warning C4244: '=': conversion from 'float' to 'int', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(621): warning C4244: '=': conversion from 'int' to 'float', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
  MainView.cpp
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(691): warning C4244: '=': conversion from 'int' to 'float', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(728): warning C4244: 'return': conversion from 'double' to 'int', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
C:\projects\sourcetrail\src\lib\component\view\GraphViewStyle.cpp(733): warning C4244: 'return': conversion from 'double' to 'int', possible loss of data [C:\projects\sourcetrail\build\win64\Sourcetrail_lib.vcxproj]
```

ninja:
```
[244/398] Building CXX object CMakeFiles\Sourcetrail_lib.dir\src\lib\component\view\GraphViewStyle.cpp.obj
..\..\src\lib\component\view\GraphViewStyle.cpp(148): warning C4244: '=': conversion from 'float' to 'int', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(319): warning C4244: '=': conversion from 'size_t' to 'float', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(319): warning C4244: '=': conversion from 'float' to 'int', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(335): warning C4244: '=': conversion from 'size_t' to 'float', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(335): warning C4244: '=': conversion from 'float' to 'int', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(360): warning C4244: '=': conversion from 'size_t' to 'float', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(360): warning C4244: '=': conversion from 'float' to 'int', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(621): warning C4244: '=': conversion from 'int' to 'float', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(691): warning C4244: '=': conversion from 'int' to 'float', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(728): warning C4244: 'return': conversion from 'double' to 'int', possible loss of data
..\..\src\lib\component\view\GraphViewStyle.cpp(733): warning C4244: 'return': conversion from 'double' to 'int', possible loss of data
```
@mlangkabel
Copy link
Contributor

Looking at the build times of our CI for this pull request it doesn't seem to speed up building. But I would like to pull this change nevertheless, because it opens up support for another build system. And if people want to keep using msbuild, that's still possible.

@mlangkabel mlangkabel merged commit f64019b into CoatiSoftware:master Dec 2, 2019
egraether pushed a commit that referenced this pull request Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants