Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kerbalism or Kopernicus -B9partswitch errors on solar panels #977

Closed
StarExplorerNeptune opened this issue Oct 22, 2020 · 14 comments
Closed
Labels
Next Release Fixed for next release

Comments

@StarExplorerNeptune
Copy link

My B9partSwitch is not working correctly with BDB, do you have any idea why?
Screenshot 2020-10-22 094824

@Clamp-o-Tron
Copy link
Contributor

I've run into this before, I can't remember how I fixed it. Maybe a reinstall or deleting the MM cache?

@StarExplorerNeptune
Copy link
Author

i found out that you need to update ksp to the newest version

@StarExplorerNeptune
Copy link
Author

i just degraded my BDB to 1.6.3 for the meantime while i update ksp to its newest version

@zorg2044
Copy link
Collaborator

@AnonymousJedi unfortunately this appears to be caused by the way some versions of Kopernicus handles solar panels. The current BDB release works properly with the latest builds of Kopernicus and should be fine in future versions. We are trying to find out what the problematic versions are, can you let us know which version exactly you were using?

Also I believe the solar panels above should be fine, the switch in power between variants wont work but I think they will be functional.

@StarExplorerNeptune
Copy link
Author

StarExplorerNeptune commented Oct 22, 2020

what kopernicus version im using?
because i do not have kopernicus

@StarExplorerNeptune
Copy link
Author

StarExplorerNeptune commented Oct 22, 2020

but also
Screenshot 2020-10-22 100129
is this a problem? and im using 1.10 @zorg2044

@zorg2044
Copy link
Collaborator

I think we might need your KSP.log to see whats going on. As well as your modulemanager.configcache

@StarExplorerNeptune
Copy link
Author

i dont know how to send those

@zorg2044
Copy link
Collaborator

@AnonymousJedi did you have Kerbalism installed?

@StarExplorerNeptune
Copy link
Author

StarExplorerNeptune commented Oct 23, 2020

yes @zorg2044

@zorg2044
Copy link
Collaborator

This appears to be a conflict with Kerbalism, we are now looking into it.

@jsolson
Copy link
Collaborator

jsolson commented Oct 23, 2020

With Kerbalism SolarPanelFixer and Reliability are added.

UrlConfig
{
	parentUrl = Bluedog_DB/Parts/ProbeExpansion/OAO/bluedog_OAO_solarUpper.cfg
	PART
	{
		name = bluedog_OAO_solarUpper
		module = Part
		author = Zorg
		rescaleFactor = 1
		node_attach = 0.0, 0.0, 0, 0.0, 0.0, 1.0
		TechRequired = spaceExploration
		entryCost = 6000
		cost = 2750
		category = Electrical
		subcategory = 0
		title = AOO-BSP-U Upper Solar Panel
		manufacturer = Bluedog Design Bureau
		description = Folding fixed solar panel for the AOO series of space obvervatories. <#CD7600> AUTHOR'S NOTE:  Attach in mirror symmetry to the sides of the AOO-WPE "Marquette" unit. A cut out on the corner of the panel allows for some overlap with the lower solar panel set. </color>
		attachRules = 0,1,0,0,1
		mass = 0.06
		dragModelType = default
		maximum_drag = 0.2
		minimum_drag = 0.2
		angularDrag = 1
		crashTolerance = 8
		maxTemp = 1200
		thermalMassModifier = 2.0
		emissiveConstant = 0.95
		heatConductivity = 0.04
		bulkheadProfiles = srf
		tags = deploy OAO AOO solar panel
		techtag = OAO
		MODEL
		{
			model = Bluedog_DB/Parts/ProbeExpansion/OAO/bluedog_OAO_solarUpper
		}
		MODULE
		{
			name = ModuleDeployableSolarPanel
			animationName = deploy
			raycastTransformName = USsunCatcher
			sunTracking = false
			pivotName = USsunCatcher
			isbreakable = true
			retractable = false
			OUTPUT_RESOURCE
			{
				name = ElectricCharge
				rate = 3
			}
			powerCurve
			{
				key = 206000000000 0 0 0
				key = 13599840256 1 0 0
				key = 68773560320 0.5 0 0
				key = 0 10 0 0
			}
		}
		MODULE
		{
			name = ModuleBdbSymmetricalPart
			transformNameA = UpperSolarLeft
			transformNameB = UpperSolarRight
			raycastTransformNameA = USsunCatcher
			raycastTransformNameB = USsunCatcher2
			pivotNameA = USsunCatcher
			pivotNameB = USsunCatcher2
			toggleSideEventGUINameA = Right Side
			toggleSideEventGUINameB = Left Side
		}
		MODULE
		{
			name = ModuleB9PartSwitch
			moduleID = meshSwitchSupport
			switcherDescription = Support Style
			switcherDescriptionPlural = Support Styles
			affectDragCubes = False
			affectFARVoxels = False
			uiGroupName = partSwitch
			uiGroupDisplayName = Part Switch
			SUBTYPE
			{
				name = Support
				title = Support On
				transform = USL_Support
				transform = USR_Support
			}
			SUBTYPE
			{
				name = NoSupport
				title = Support Off
			}
		}
		MODULE
		{
			name = ModuleB9PartSwitch
			moduleID = meshSwitchExtension
			switcherDescription = Extension
			switcherDescriptionPlural = Extentions
			affectDragCubes = False
			affectFARVoxels = False
			uiGroupName = partSwitch
			uiGroupDisplayName = Part Switch
			SUBTYPE
			{
				name = Angled
				transform = USR_extensionPivotAngled
				transform = USL_extensionPivotAngled
			}
			SUBTYPE
			{
				name = OAO1
				addedMass = -0.0025
				MODULE
				{
					IDENTIFIER
					{
						name = *SolarPanel*
					}
					DATA
					{
						OUTPUT_RESOURCE
						{
							name = ElectricCharge
							rate = 2.5
						}
					}
				}
			}
			SUBTYPE
			{
				name = Straight
				transform = USR_extensionPivotStraight
				transform = USL_extensionPivotStraight
			}
		}
		MODULE
		{
			name = SolarPanelFixer
			OUTPUT_RESOURCE
			{
				name = ElectricCharge
				rate = 3
			}
		}
		MODULE
		{
			name = Reliability
			type = SolarPanelFixer
			title = Solar Panel
			redundancy = Power Generation
			repair = true
			mtbf = 36288000
			extra_cost = 2.5
			extra_mass = 1.0
			rated_radiation = 0.15
			radiation_decay_rate = 1
		}
		MODULE
		{
			name = ModuleB9PartInfo
		}
	}
}

@hemeac
Copy link
Contributor

hemeac commented Oct 31, 2020

One solution may be to add a custom variable to all ModuleDeployableSolarPanel in which you are using a B9 transform on

For example you could have:

MODULE
	{
		name = ModuleDeployableSolarPanel
		animationName = deploy
		raycastTransformName = USsunCatcher
		sunTracking = false
		pivotName = USsunCatcher
		isbreakable = true
		retractable = false
		//resourceName = ElectricCharge
		//chargeRate = 16
		bdb = true

		OUTPUT_RESOURCE
		{
			name = ElectricCharge
			rate = 3
		}

		powerCurve
		{
			key = 206000000000 0 0 0
			key = 13599840256 1 0 0
			key = 68773560320 0.5 0 0
			key = 0 10 0 0
		}
	}

And then for the ModuleB9PartSwitch:

MODULE
	{
		name = ModuleB9PartSwitch
		moduleID = meshSwitchExtension
		switcherDescription = Extension
		switcherDescriptionPlural = Extentions
		affectDragCubes = False
		affectFARVoxels = False
		SUBTYPE
		{
			name = Angled
			transform = USR_extensionPivotAngled
			transform = USL_extensionPivotAngled
		}
		SUBTYPE
		{
			name = OAO1
			addedMass = -0.0025

			MODULE
			{
				IDENTIFIER
				{
				name = *SolarPanel*
				bdb = true
				}
				DATA
				{
					OUTPUT_RESOURCE
					{
							name = ElectricCharge
							rate = 2.5
					}
				}
			}
		}
		SUBTYPE
		{
			name = Straight
			transform = USR_extensionPivotStraight
			transform = USL_extensionPivotStraight
		}
	}

B9 should then has two conditions that need to be satisfied. That should fix the issue with the B9 also matching with the Kerbalism Solar Panel fixer. Or if you don't want to use a new variable, just choose another variable within the ModuleDeployableSolarPanel that is not present within another module that has SolarPanel

@jsolson jsolson changed the title B9partswitch problem Kerbalism-B9partswitch problem Nov 7, 2020
hemeac added a commit to hemeac/Bluedog-Design-Bureau that referenced this issue Nov 20, 2020
Add a second identifier in the B9 Part Switch to fix Issue CobaltWolf#977 . Tested both with Kerbalism and BDB and separately JNSQ and BDB to ensure that compatibility was maintained.
jsolson pushed a commit that referenced this issue Nov 21, 2020
Add a second identifier in the B9 Part Switch to fix Issue #977 . Tested both with Kerbalism and BDB and separately JNSQ and BDB to ensure that compatibility was maintained.
@zorg2044
Copy link
Collaborator

zorg2044 commented Mar 4, 2021

This issue seems resolved with the latest version of Kopernicus and Kerbalism.

@zorg2044 zorg2044 added the Next Release Fixed for next release label Mar 14, 2021
@zorg2044 zorg2044 changed the title Kerbalism-B9partswitch problem Kerbalism or Kopernicus -B9partswitch errors on solar panels Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Release Fixed for next release
Projects
None yet
Development

No branches or pull requests

5 participants