Fix warnings #33
Merged
Fix warnings #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use newer versions of elixir * check format and compiler warnings
Accessing the stacktrace outside of a rescue/catch is deprecated. Adding a deprecation as of now. Also erlang:get_stacktrace is deprecated (which is what elixir is calling now) and from OTP 23 onwards get_stacktrace will return `[]` and it will be removed in OTP 24. The get_stacktrace call used in logger is a stop gap solution. Proper solution might need major changes to logger module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to not make any code changes. Nearly all of them are formatting changes or straight forward changes to fix the warnings.