Fix store replays #2301
Merged
Fix store replays #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason we have a variable in the servers ini to enable/disable the storing of replays but there is no code that uses that variable. At one time there was but in light of it being removed some were along the line this add's the ability back in for server owners to disable the storing of game replay data.
Moved the check for storing replay information into existing routine.
ZeldaZach
reviewed
Dec 7, 2016
| @@ -156,12 +154,15 @@ void Server_Game::storeGameInformation() | |||
| while (allUsersIterator.hasNext()) { | |||
| Server_AbstractUserInterface *userHandler = server->findUser(allUsersIterator.next()); | |||
| if (userHandler) | |||
| userHandler->sendProtocolItem(*sessionEvent); | |||
| if (server->getStoreReplaysEnabled()) | |||
There was a problem hiding this comment.
Maybe just put these into a single if (userHandler && server->getStoreReplaysEnabled())?
There was a problem hiding this comment.
I know you were going to suggest that. The reason I didnt was due to me working on adding additional code in that block area that I ended up backing out.
ZeldaZach
approved these changes
Dec 7, 2016
Combined lines per request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the server side store replay enable/disable functionality. Not sure when it was broken but we have a variable definition that allows owners to enable/disable the storing of replays but no underlying code that does the actual work. This fixes that.