add player numbers to in game #2435
Conversation
|
Works very nice on game room join and displays the count in the title of the widget or undocked window. Also works in tabbed mode. But if players join it doesn't update at all and keeps the initial value: So what's the difference, that it instantly updates in the game view list but not here? |
cockatrice/src/tab_game.cpp
Outdated
| } | ||
| playerListWidget->addPlayer(playerInfo); | ||
|
|
||
| qDebug() << "eventJoin retranslate w/ count = " << playerCountInRoom; | ||
| retranslateUi(); |
There was a problem hiding this comment.
I think emitUserEvent causes a retranslateUi to fire already - can you check?
cockatrice/src/tab_game.cpp
Outdated
| @@ -420,6 +421,8 @@ TabGame::TabGame(TabSupervisor *_tabSupervisor, QList<AbstractClient *> &_client | |||
|
|
|||
| this->installEventFilter(this); | |||
| QTimer::singleShot(0, this, SLOT(loadLayout())); | |||
|
|
|||
| playerCountInRoom = gameInfo.player_count(); | |||
cockatrice/src/tab_game.cpp
Outdated
|
|
||
| cardInfoDock->setWindowTitle(tr("Card Info") + (cardInfoDock->isWindow() ? tabText : QString())); | ||
| playerListDock->setWindowTitle(tr("Player List") + (playerListDock->isWindow() ? tabText : QString())); | ||
| playerListDock->setWindowTitle(tr("Player List") + userCountInfo + (playerListDock->isWindow() ? tabText : QString())); |
There was a problem hiding this comment.
You can get the number of players from the PlayerListWidget, just adding a method like:
int PlayerListWidget::getPlayersCount() { return players.size(); }
|
@ctrlaltca Can you take over this PR? I'm not sure how to get it to work properly as nothing I've done suffices to get the correct data. |
Please look https://github.com/ZeldaZach/Cockatrice/pull/3 |
|
This works as expected now. Thanks @ctrlaltca. Care to explain why your method works? |
The TabGame object already takes care of maintaining a list of the actual players and spectators. I just get the information from it when needed, instead of maintaining another counter and handling all the exceptions. |
|
Working now. It also just counts real players, no spectators! 👍 |
Fix #2417