-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide some icons for spectators; fix #2589 #2656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't test "during sideboard" with sideboard unlocked.
Edit:
Rechecked with the newest beta... and I get the same pictures.
So I don't understand the change - what was the initial problem @Daenyth?
Also doublechecked the about window for version. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, nice change
I think it's because there's 8/8 players in that shot |
The "not ready" icon appears on spectators when the game stops, so:
Now you should be back to the "sideboard" screen and both the player and the spectator will show the "not ready" icon. |
Nope, same result with a 7/8 player game. |
Related Ticket(s)
Short roundup of the initial problem
In the player list widget, spectators could have icons indicating they are ready/not ready ect..
What will change with this Pull Request?
Status, deck hash and sideboard locked icons are hidden for spectators.