Hide some icons for spectators; fix #2589

[ctrlaltca]

Related Ticket(s)

• Fixes Player list in game shows ready/not ready icon for spectators #2589

Short roundup of the initial problem

In the player list widget, spectators could have icons indicating they are ready/not ready ect..

What will change with this Pull Request?

Status, deck hash and sideboard locked icons are hidden for spectators.

[tooomm]

Waiting for game to start:

During a game:

Couldn't test "during sideboard" with sideboard unlocked.

Edit:
Rechecked with the newest beta... and I get the same pictures.
So I don't understand the change - what was the initial problem @Daenyth?
Also doublechecked the about window for version. ;)

[Nightfirecat]

@tooomm From @Daenyth's original issue, there is a ready/not-ready icon next to spectators despite the fact they cannot affect a game's readiness. This PR removes that indicator for spectators, as evidenced in your "Waiting for game to start" screenshot.

[ZeldaZach]

Works as expected, nice change

[tooomm]

Well... to me this looks exactly the same running the beta without this pr!? What do I miss?

[Daenyth]

I think it's because there's 8/8 players in that shot

[ctrlaltca]

The "not ready" icon appears on spectators when the game stops, so:

• Create a game, even 1 player only
• join with a spectator
• start the game
• concede the game

Now you should be back to the "sideboard" screen and both the player and the spectator will show the "not ready" icon.

[tooomm]

I think it's because there's 8/8 players in that shot

Nope, same result with a 7/8 player game.
But yeah, as @ctrlaltca explained it's only displayed in some special conditions.